search

intel / dffml

The easiest way to use Machine Learning. Mix and match underlying ML libraries and data set sources. Generate new datasets or modify existing ones with ease.
https://intel.github.io/dffml/main/
MIT License
253 stars 138 forks source link

dffml: plugins: Autosklearn should not be added for Windows OS #887

Closed yashlamba closed 4 years ago

yashlamba commented 4 years ago

Just went through this: https://automl.github.io/auto-sklearn/master/installation.html#windows-osx-compatibility

It's an easy fix, to check for the os and then add it to the plugins list.

SGeetansh commented 4 years ago

Is it okay if I give it a shot?

johnandersen777 commented 4 years ago

@SGeetansh Yes! The plugins list is in dffml/plugins.py, look for the if block around daal4py and how it isn't added to the list for Python 3.8. Do the same for autosklearn if platform.system() is "Windows". A CHANGELOG.md entry is not necessary for this PR.

SGeetansh commented 4 years ago

Should I check just for Windows or macOS too? Because I don't think it supports macOS for now. https://automl.github.io/auto-sklearn/master/installation.html#mac-osx

johnandersen777 commented 4 years ago

Ah, yes. Please do check for both.