intel / dleyna-control

dLeyna-control is a Digital Media Player written in python to demonstrate how to use the dleyna DMS APIs. It detects Digital Media Servers on the local area network and allows users to browse, search and play their contents.
https://01.org/dleyna/
GNU Lesser General Public License v2.1
8 stars 12 forks source link

Make Browse work asynchronously as well #9

Closed jku closed 11 years ago

jku commented 11 years ago

The ground work was laid in the search PR, now let's start using it in Browse as well.

markdryan commented 11 years ago

Hi Jussi,

This is working really well. I even gave it the acid test, testing against a crappy DMS running on my n900 that publishes over 2500 songs. The UI works perfectly and is really responsive. You see the "Loading" string for a second and then it get's replaced by the real song titles. This is also much faster than it was before. The old tree model always issued multiple requests even if the data being requested was not on the screen.

Just one comment. Pychecker is reporting a warning about fetch_items not being defined in msd_generic_model. I don't know enough about python to know if this is really a problem or not.

Mark

jku commented 11 years ago

On 8 March 2013 15:10, markdryan notifications@github.com wrote:

Hi Jussi,

This is working really well. I even gave it the acid test, testing against a crappy DMS running on my n900 that publishes over 2500 songs. The UI works perfectly and is really responsive. You see the "Loading" string for a second and then it get's replaced by the real song titles. This is also much faster than it was before. The old tree model always issued multiple requests even if the data being requested was not on the screen.

Just one comment. Pychecker is reporting a warning about fetch_items not being defined in msd_generic_model. I don't know enough about python to know if this is really a problem or not.

Good to hear!

GenericModel is a virtual class, and the subclasses need to implement fetch_items(), so the warning isn't real: I can add a default method that always raises an exception to silence the warning though.

Jussi