search

intel / dleyna-renderer

dleyna-renderer is a library for implementing services that allow clients to discover and manipulate Digital Media Renderers. An implementation of such a service for linux is also included
https://01.org/dleyna/
GNU Lesser General Public License v2.1
16 stars 19 forks source link

dlr_async_task_complete cleanup #13

Open lferrandis opened 11 years ago

lferrandis commented 11 years ago

This function is always called in a g_idle_add Check if needed, and move g_idle_add inside the function If not needed, remove all g_idle_add

markdryan commented 11 years ago

It's probably best to leave things the way they are, i.e., to continue to use g_idle. Otherwise, if an error occurs, you could get callbacks being called when they are not expected, resulting in a task being deleted before it has actually been processed. It's far to easy to get segmentation faults this way.