daemon: use GLib signal handling

intel / dleyna-renderer

dleyna-renderer is a library for implementing services that allow clients to discover and manipulate Digital Media Renderers. An implementation of such a service for linux is also included

https://01.org/dleyna/

GNU Lesser General Public License v2.1

16 stars 19 forks source link

daemon: use GLib signal handling #142

Closed desrt closed 10 years ago

desrt commented 10 years ago

Make use of GLib signal handling instead of signalfd. This has several advantages:

signalfd is not well-defined in processes where you do not control the creation of all threads (and in particular their signal mask). GLib implicitly creates threads, so you should not use signalfd here.
signalfd is not portable which prevents dleyna-renderer from building on non-Linux systems (which it otherwise would)
using the GLib API gives a substantial reduction in complicated code

em- commented 10 years ago

Nice, this would probably save me from marking the dLeyna Debian packages with arch:linux-any, since signalfd indeed prevents them from building on kfreeBSD and Hurd.

After merging the patch a point release would be much appreciated. :D

jku commented 10 years ago

Apologies for total lack of action. Patch looks great.

Could I still ask you to add a signed-off-by line (again, sorry for not asking for it months ago)?

jku commented 10 years ago

Committed, thanks.