intel / dleyna-renderer

dleyna-renderer is a library for implementing services that allow clients to discover and manipulate Digital Media Renderers. An implementation of such a service for linux is also included
https://01.org/dleyna/
GNU Lesser General Public License v2.1
16 stars 19 forks source link

Need to check output parameters of gupnp_service_proxy_end_action #51

Closed markdryan closed 11 years ago

markdryan commented 11 years ago

The problem is that although UPnP servers are obliged to provide all the output parameters specified for a method in the SCPD, they don't always do this. Our code assumes that if this happens, GUPnP will return an error. Unfortunately, it does not. It simply issues a warning to the logs. This can mean that gupnp_service_proxy_end_action can return true without initialising our output parameters.

A bug (https://bugzilla.gnome.org/show_bug.cgi?id=69709) has been entered in GUPnP on this. However, as the fix would require a slight change to the behaviour of an API, the bug will not be fixed any time soon. So we'll need to fix this ourselves in dLeyna-renderer, by initialising parameters to default values and checking them. A similar bug has been entered for dLeyna-server.

https://github.com/01org/dleyna-server/issues/49

markdryan commented 11 years ago

Fixed by PR #54