[Device] Add X_DLNA_PS transport action support - v3

[cguiraud]

• re-order all the transport play-speed lists provided by the server with g_list_sort().
• when we reset the playspeeds with the default renderer ones, we now also check the transport play speed list property to do not send a property changed signal if it doesn't change. check is done with the help of the g_variant_equal func.

---

• Add the X_DLNA_PS transport action support to allow the playspeeds provided by the renderer once we have provided it a URI (SetAVTransportURI()) in addition to the renderer default playspeeds retrieved via the introspection. MINIMUM_RATE, MAXIMUM_RATE and TRANSPORT_PLAY_SPEEDS properties will be upddated.

when SetAVTransportURI() action is called, MINIMUM_RATE, MAXIMUM_RATE and TRANSPORT_PLAY_SPEEDS properties will be reset with the renderer default playspeeds.

• The renderer default playspeeds are stored in the dlr_devicet structure to be re-used without having to be re-computed.
• When the application set the property RATE, the new rate value is checked with either the renderer default allowed playspeeds or the X_DLNA_PS allowed playspeeds depending on the availability of the X_DLNA_PS.
• We now emit a property changed signal when application set the DLR_INTERFACE_PROP_MINIMUM_RATE property with a value not equal to the current one.
• For the parsing of the action string containing the X_DLNAPS content, thanks to regexp API, the sequence "\," are replaced by "" ("\," is used to separated the X_DLNA_PS speeds), then the action string is splitted by "," to separate each actions token. For getting the X_DLNAPS playspeeds we then just have to split the string with ""

action string = Play,Stop,Seek,X_DLNA_PS=-8\,2\,4\,8

Signed-off-by: Christophe Guiraud christophe.guiraud@intel.com

[cguiraud]

I've tested with a BRAVIA TV which provides default speeds list with (-120.0,-30.0,-10.0,1.0,10.0,30.0,120.0) and also provide the X_DLNA_PS action with also (-120.0,-30.0,-10.0,1.0,10.0,30.0,120.0) values.

[markdryan]

Great. I'll test the patch today with WMP and XBOX 360.

[cguiraud]

yes the dev->mpris_transport_play_speeds is only set once during the initialization of the device (from the transport service description xml), it's a kind of default device value. when we check a rate validity upon a set prop rate request, we first try to use the dynamic speeds (device->dlna_transport_play_speeds) if they are available and if not we fallback on the default ones (dev->mpris_transport_play_speeds).

[markdryan]

Christophe,

Okay, I'm a bit confused now

When prv_set_rate is called it calls prv_get_rate_value_from_double.

prv_get_rate_value_from_double iterates through device->mpris_transport_play_speeds (tps) and checks to see if the new rate is in device->mpris_transport_play_speeds. If the new rate is not in device->mpris_transport_play_speeds it cannot be set. So I can't see how any rate in DLNA_PS that are not in the service file can be set.

[cguiraud]

ok, you're right I've missed here that tps should also be set with the dynamic speed list in "mpris" format, i.e TRANSPORT_PLAY_SPEEDS prop value, in the case where we have device->dlna_transport_play_speeds != NULL. I fix this if you agree

[markdryan]

Sounds good.