[Build] Do not require dbus and dleyna-connector-dbus at build time

intel / dleyna-renderer

dleyna-renderer is a library for implementing services that allow clients to discover and manipulate Digital Media Renderers. An implementation of such a service for linux is also included

https://01.org/dleyna/

GNU Lesser General Public License v2.1

16 stars 19 forks source link

[Build] Do not require dbus and dleyna-connector-dbus at build time #89

Closed em- closed 11 years ago

em- commented 11 years ago

DBus and the DBus connector are only needed at runtime and dropping the pkg-config checks in ./configure allows the build to succeed even in restricted build environment with minimal dependecies.

em- commented 11 years ago

The same change applies to dleyna-server, let me know if you prefer me opening a new pull request there or if you take care of the porting. Thanks!

markdryan commented 11 years ago

Well DBus isn't needed at all any more I don't think. This was needed at build time in the past to retrieve the correct location to install the service files but we don't do it like that any more.

Also, I guess someone might want to create their own connector and use this with dLeyna-server-service rather than using the dbus connector. Currently, they would be forced to compile a component (dleyna-connector-dbus) that they would not use to compile dLeyna-server-service.

So I have no objections to removing this code.

Regis, what about you?

rmerlino commented 11 years ago

I am fine with that too. I will perform the merge into upstream and apply the same change for dleyna-server.

rmerlino commented 11 years ago

Merged.