search

intel / dleyna-server

dleyna-server is a library for implementing services that allow clients to discover, browse and manipulate Digital Media Servers. An implementation of such a service for linux is also included.
https://01.org/dleyna/
GNU Lesser General Public License v2.1
28 stars 28 forks source link

Missing TLS certificate verification #169

Open mcatanzaro opened 3 years ago

mcatanzaro commented 3 years ago

Hi, libdylena's device.c does not appear to be enabling TLS certificate verification on the SoupSessionAsync object it creates. You have to do this manually when using the deprecated SoupSessionAsync.

phako commented 3 years ago

I suppose the linked fix above should suffice?

mcatanzaro commented 3 years ago

I suppose the linked fix above should suffice?

That's the best way to fix this issue, yes, assuming you've read the porting guide and are OK with the differences.

mcatanzaro commented 3 years ago

Note there is an identical issue in dleyna-renderer: https://github.com/intel/dleyna-renderer/issues/171

phako commented 3 years ago

Yes that should not matter here. I have fixed the renderer issue as well, the commit should be referenced in that ticket.