GregBurns
commented
4 years ago I see some CI failures – I should hold off on the merge while you look at them
From: Todd Malsbary notifications@github.com Sent: Monday, October 21, 2019 4:28 PM To: intel/dps-for-iot dps-for-iot@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [intel/dps-for-iot] Discovery2 (#112)
Improve discovery service APIs and add DPS_ShutdownNode() API to cleanly unlink any remotes.
You can view, comment on, or merge this pull request online at:
https://github.com/intel/dps-for-iot/pull/112
Commit Summary
- Remove unnecessary creation of RemoteNodes.
- Fix memory leak on error path.
- Update the history for stale publications.
- Fix issue selecting closest publisher for an ACK.
- Colorize graph and add some stats.
- Fix off-by-one in path length calculation.
- Don't overwrite history with stale values.
- Use alphabetic topics for ease of debugging.
- Don't overwrite in-progress completion.
- Merge remote-tracking branch 'upstream/discovery' into discovery2
- Fix error print.
- Add tool for creating gcc shared library map file.
- Safely destroy the discovery service.
- Don't export functions unnecessarily.
- Remove unnecessary prefix from static functions.
- Fix compilation error.
- Fix potential double-free.
- Safely destroy the discovery service.
- Fixup debug logging in discovery service.
- Allow an application to reset the discovery schedule.
- Provide for application-level discovery payloads.
- Add application data pointer to discovery service.
- Ack timers must complete before freeing service.
- Allow self discovery.
- Add publication to discovery handler.
- Publish an empty discovery message on destruction.
- Provide UUID of sender in discovery ACK.
- Add -m option to discovery test.
- Structure the discovery payloads.
- Don't call discovery handler until linked.
- Add a destroyed callback to the discovery service.
- LinkCb may be called after service is destroyed.
- Merge remote-tracking branch 'upstream/discovery2' into discovery2
- Fix memory leak introduced in merge.
- Handler must be called even when link exists.
- Merge remote-tracking branch 'upstream/discovery2' into discovery2
- Merge remote-tracking branch 'upstream/discovery2' into discovery2
- Correct a couple comments.
- addr should be const for both DPS_Link and DPS_Unlink callbacks.
- Call link callback even when DPS_AddRemoteNode fails.
- Fix versioning test.
- Fix fragile tutorial test.
- Use debug print instead of print.
- Replace error print with debug print.
- Include address in link result when available.
- Plumb subscription rate through to reg_subs test.
- Add the test topics to DPS_DumpMatchingTopics for easier debugging.
- Include UUID in debug print.
- Improve debug logging for interests.
- Don't update inbound interests twice with same interests.
- Send interests in case of a tie or simultaneous link.
- Merge remote-tracking branch '01org/discovery2' into discovery2
- Report DPS_OK when linking to existing passive link.
- Add additional link tests.
- DPS_RemoteCompletion must be called with the lock.
- Merge remote-tracking branch 'upstream/discovery2' into discovery2
- Change error print to debug prints.
- Initialize all of resurrected remote node's state.
- Move some error prints to warning prints.
- Use correct revision in unlink SAK.
- Unlink correctly when DPS_Registration_Get() is done.
- Add _subs_rate to reg_pubs test.
- Send interests when link collision.
- Add const to DPS_MinMeshId and RemoteStateTxt.
- Merge remote-tracking branch 'upstream/discovery2' into discovery2
- Fixups after merge commit.
- Do not send interests delta on first SUB response.
- Add new SUB flag to docs.
- Merge remote-tracking branch 'upstream/discovery2' into discovery2
- Add DPS_ShutdownNode() API to cleanly unlink all remote nodes.
- Add missing exports.
- Fix memory leak in StopNode.
- Fix double-free in discovery service.
- Fix potential NULL dereferences.
- Only schedule LinkExists when no other activity is pending.
- Tighten up shutdown error handling.
- Issue completion in all cases.
- Prevent double-free of completions.
- Fix invalid memory access.
- Link completions must be serialized also.
- Merge remote-tracking branch 'upstream/discovery2' into discovery2
- Fix debug print format.
File Changes
- M doc/Message-Types-and-Flows.doxhttps://github.com/intel/dps-for-iot/pull/112/files#diff-0 (3)
- M dps_shared.defhttps://github.com/intel/dps-for-iot/pull/112/files#diff-1 (6)
- M inc/dps/discovery.hhttps://github.com/intel/dps-for-iot/pull/112/files#diff-2 (121)
- M inc/dps/dps.hhttps://github.com/intel/dps-for-iot/pull/112/files#diff-3 (97)
- M inc/dps/private/dps.hhttps://github.com/intel/dps-for-iot/pull/112/files#diff-4 (22)
- M libdps_shared.maphttps://github.com/intel/dps-for-iot/pull/112/files#diff-5 (6)
- M src/ack.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-6 (33)
- M src/discovery.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-7 (926)
- M src/dps.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-8 (487)
- M src/dtls/network.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-9 (8)
- M src/history.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-10 (16)
- M src/node.hhttps://github.com/intel/dps-for-iot/pull/112/files#diff-11 (44)
- M src/pub.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-12 (47)
- M src/pub.hhttps://github.com/intel/dps-for-iot/pull/112/files#diff-13 (43)
- M src/registration.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-14 (2)
- M src/sub.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-15 (44)
- M src/topics.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-16 (36)
- M src/udp/network.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-17 (10)
- M swig/dps.ihttps://github.com/intel/dps-for-iot/pull/112/files#diff-18 (10)
- M test/discover.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-19 (37)
- M test/link.chttps://github.com/intel/dps-for-iot/pull/112/files#diff-20 (435)
- M test_scripts/common.pyhttps://github.com/intel/dps-for-iot/pull/112/files#diff-21 (2)
- M test_scripts/discover.pyhttps://github.com/intel/dps-for-iot/pull/112/files#diff-22 (52)
- A tools/exports_gcchttps://github.com/intel/dps-for-iot/pull/112/files#diff-23 (12)
Patch Links:
- https://github.com/intel/dps-for-iot/pull/112.patch
- https://github.com/intel/dps-for-iot/pull/112.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/intel/dps-for-iot/pull/112?email_source=notifications&email_token=ACESB66KZDGPRBIMW7RB3W3QPY3JNA5CNFSM4JDIA6Y2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTLK4BA, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACESB6Y6BRRVTUUBEWRKHQLQPY3JNANCNFSM4JDIA6YQ.
malsbat
Improve discovery service APIs and add DPS_ShutdownNode() API to cleanly unlink any remotes.