search

intel / dps-for-iot

Other
61 stars 23 forks source link

Add upstream check to Travis CI that builds dps-for-iot via rmw_dps #99

Closed AAlon closed 5 years ago

AAlon commented 5 years ago

Depends on https://github.com/ros2/rmw_dps/pull/29 (CI is expected to fail here until we merge that)

Changes made to dps-for-iot do not trigger a build of rmw_dps. This is a proposal to add an additional Travis CI build job so that for every change made to dps-for-iot, we will also build rmw_dps with that change, thus helping to ensure compatibility between rmw_dps & dps-for-iot.

The new job will be different than the existing ones in that it will not build DPS directly; instead, it will clone the latest rmw_dps and patch the URL that points to dps-for-iot, so that it'll point to the local version.

AAlon commented 5 years ago

Note: the script section should probably be split into separate jobs e.g.:

jobs:
  include:
    - stage: build
      script: scons ...

    - stage: test
      script: ./test_scripts/run.py ...

    - stage: upstream-compatibility-check
      script: ./.travis/upstream-check.sh

and so we can avoid that FROM_UPSTREAM variable. I'll do that as a follow up.

AAlon commented 5 years ago

@malsbat could you restart the Travis build please? Thanks!