intel / dptf

Other
87 stars 32 forks source link

Chrome Makefiles need a bit of clean up #2

Closed vapier closed 10 years ago

vapier commented 10 years ago

the current Makefiles (Products/ESIF_UF/Chrome86/Release/ and such) have issues (these aren't specific to Chromium OS ... these apply to all the Makefiles):

ifneq ($(filter default undefined,$(origin CC)),)
CC := gcc
endif
# These are the defaults.
CFLAGS ?= -o9 -m32 -pipe ...
# These are the ones we want to always use.
CFLAGS += -Wno-multichar
CPPFLAGS += -I...all the inc paths...
CPPFLAGS += -D...all the defines...
...
%.o: %.c $(DEPS)
   $(CC) $(CFLAGS) $(CPPFLAGS) -c -o $@ $<
esif_ufd: $(OBJ)
   $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^ $(LDLIBS)
bgeltz commented 10 years ago

Thanks for the feedback! We'll be incorporating this today and it will be pushed to GitHub soon.