intel / external-mesa

16 stars 57 forks source link

Mesa Static link with libexpat #57

Closed Kishore409 closed 6 years ago

Kishore409 commented 6 years ago

Mesa Static link with libexpat In Android O, MESA needs to statically link libexpat so that it's in same namespace.

Signed-off-by: Kishore Kadiyala kishore.kadiyala@intel.com

tpalli commented 6 years ago

Why libexpat, is there particular issue with that?

Kishore409 commented 6 years ago

After introducing treble, dynamic linking of lib with MESA is not happening. We had workaround for it as temporary fix . Meanwhile when contacted google, they suggested that , MESA should statically link libexpat.

tpalli commented 6 years ago

Right, I'm just wondering how does it work for other libs like libz, liblog (?) I guess it would be good to upstream these changes.

kalyankondapally commented 6 years ago

@harishkrupo will be sending it out for review. While it's ongoing can we get this merged here @tpalli

harishkrupo commented 6 years ago

@tpalli @kalyankondapally Sure. I will. Is the commit message enough?

Right, I'm just wondering how does it work for other libs like libz, liblog (?)

Yeah, how come these two libraries link fine?

tpalli commented 6 years ago

When sending upstream it would be good to mention what is failing and how to trigger it. As example with current Android-IA things work fine without this change so one would think there is no problem.

kalyankondapally commented 6 years ago

@tpalli Dont think Android IA enables full treble mode yet. On that note, I dont think we can send this upstream yet.

@tpalli @harishkrupo Those might be whitelisted as lot of components use those packages. libexpat is not used by anyone except mesa.

tpalli commented 6 years ago

Right I see .. let's use this just internally for now then.

kalyankondapally commented 6 years ago

merged

Kishore409 commented 6 years ago

Will be posting an updated, closing this PR