search

intel / external-mesa

16 stars 57 forks source link

Revert "egl: EXT_pixel_format_float plumbing" #69

Closed Kishore409 closed 6 years ago

Kishore409 commented 6 years ago

This reverts commit 41f7de477c68a5ae3fd8b086dfb4a8cc10a35c39. This patch makes Android enable wide color gamut support which results in whitescreen after boot.

Android Boot log for reference [MR1]: 11-11 11:11:23.225 3359 3408 I zygote64: android::hardware::configstore::V1_0::ISurfaceFlingerConfigs:: hasWideColorDisplay retrieved: 0 11-11 11:11:23.225 3359 3408 I OpenGLRenderer: Initialized EGL, version 1.4 11-11 11:11:23.225 3359 3408 D OpenGLRenderer: Swap behavior 2 11-11 11:11:23.225 3359 3408 F OpenGLRenderer: Device claims gide gamut support, cannot find matching config, error = EGL_SUCCESS --------- beginning of crash 11-11 11:11:23.225 3359 3408 F libc : Fatal signal 6 (SIGABRT), code -6 in tid 3408 (RenderThread), pid 3359 (ndroid.settings)

Jira: None Test: Boot to Android Home screen Signed-off-by: Kishore Kadiyala kishore.kadiyala@intel.com

kalyankondapally commented 6 years ago

merged

tpalli commented 6 years ago

Right, I was kind of afraid this would happen. It is Android that is broken here, this patch should not enable wide color support ... but we can't do anything about it. It would be interesting to know what kind of config it would want. I will revert this also from upstream.

tpalli commented 6 years ago

It's now fixed in Android: https://android-review.googlesource.com/c/platform/frameworks/base/+/550746

So at some point we should be able to stop reverting the patch.