intel / external-mesa

16 stars 57 forks source link

i965: perf: implement GPA's null renderer #88

Closed yugang closed 6 years ago

yugang commented 6 years ago

GPA requires a null renderer query which disables all rendering. This feels fairly at odds with the spirit of the INTEL_performance_query extension.

Test: Pass mdapi test_GfxDrv_DriverAcceptance test case GfxDrv_DriverAcceptanceQuery.GL_NULL_HARDWARE and has no reg issue Signed-off-by: Landwerlin, Lionel lionel.g.landwerlin@intel.com

submit https://github.com/djdeath/mesa/commit/ba47f5fdb998d2fb6d0175f940f17070cf63c874 to fix MDAPI tests GfxDrv_DriverAcceptanceQuery.GL_NULL_HARDWARE in Android

js0701 commented 6 years ago

@kalyankondapally

strassek commented 6 years ago

@djdeath Do you think there is a path to getting this patch accepted upstream?

djdeath commented 6 years ago

I don't think so because this is clearly a introducing a behavior that has nothing to do with performance queries. We published another extension to implement the same behavior : https://www.khronos.org/registry/OpenGL/extensions/INTEL/INTEL_blackhole_render.txt Unfortunately the effort kind of stalled : https://patchwork.freedesktop.org/series/40035/

strassek commented 6 years ago

Thanks Lionel!

@yugang Can we try to land INTEL_blackhole_render instead?

yugang commented 6 years ago

@strassek considering the INTEL_blackhole_render need test case changes and also need time to review in upstream(i tried the INTEL_blackhole_render and met the failure, and confirmed with Lionel that the tests need changes. i think the tests should be changeed once the INTEL_blackhole_render get merge in upstream), but the Android milestone is so urgent, so i suggest we can use this patch firstly, and rebase it once the INTEL_blackhole_render and tests get merged.

strassek commented 6 years ago

Understood, in that case lets prepend the commit subject with "REVERTME: ..." and add a note in the body with an explanation and a link to Lionel's series. It could be a long time until someone looks at this again.

yugang commented 6 years ago

@strassek , thanks for your comments, and updated the PR already

yugang commented 6 years ago

@js0701 @kalyankondapally @jennycao not sure if can merge it for next release?

js0701 commented 6 years ago

Will merge if no more comments. @yugang

strassek commented 6 years ago

I have a rebase + this patch running through dEQP atm, I'll push it to master tomorrow morning.

strassek commented 6 years ago

Merged