search

intel / external-mesa

16 stars 57 forks source link

[ww33] dEQP-VK.api.info.device#extensions failed on android #89

Closed jennycao closed 6 years ago

jennycao commented 6 years ago

CTS version: 9.0_R1 Following test failed. dEQP-VK.api.info.device#extensions | fail

tpalli commented 6 years ago

This fails because Mesa implements various Vulkan extensions that Android test is not aware of. I'm not sure we want to 'fix this'. In practice it seems to be enough to make this pass when I disable VK_KHR_8bit_storage and VK_KHR_create_renderpass2 extensions.

renchenglei commented 6 years ago

@tpalli CTS ask to 100% PASS on Android. So I am afraid we have to fix this issue. If this is one defect in test case side, could we try to prepare one PR for it?

tpalli commented 6 years ago

Hmm actually now when I run this passes for me. When I compile dEQP from P sources and run tests with 'dEQP-VK.api.info*extensions' I get total 4 passing tests.

renchenglei commented 6 years ago

@tpalli We used Google official released CTS package, and I got 3/4 pass. You could get it from https://source.android.com/compatibility/cts/downloads. Not sure, if there is new changes from test case side, I will check it. :)

tpalli commented 6 years ago

@renchenglei ok, maybe they've updated the test, I can prepare a PR that makes this test pass meanwhile

tpalli commented 6 years ago

@renchenglei nevermind, I had the fix in place when testing, I'll send the fix.

tpalli commented 6 years ago

https://github.com/intel/external-mesa/pull/96

renchenglei commented 6 years ago

@tpalli Ok, that's great! Thanks for the fix! :)

strassek commented 6 years ago

@jennycao This should now be fixed in master, please retest.

jennycao commented 6 years ago

@strassek @renchenglei this test is passed on ww36's deqp tests. after the fix patch #96 merged Thanks for the fix