intel / fpga-runtime-for-opencl

Intel® FPGA Runtime for OpenCL™ Software Technology
Other
34 stars 68 forks source link

Informally support atomic fence capability device query #345

Closed sophimao closed 8 months ago

sophimao commented 8 months ago

Also require DSE change to fully work in SYCL, so making a draft PR for now.

zibaiwan commented 8 months ago

Thread sanitizer failure was strange. Not sure what happened, triggered a rerun.

zibaiwan commented 8 months ago

Thread sanitizer failure was strange. Not sure what happened, triggered a rerun.

Rerun also failed... Checked the OS version between this one and previously passing run, same OS, so should be no difference in the thread sanitizer version. Rerunning the previous passed workflow in another PR: https://github.com/intel/fpga-runtime-for-opencl/actions/runs/8071872741?pr=342

zibaiwan commented 8 months ago

Thread sanitizer failure was strange. Not sure what happened, triggered a rerun.

Rerun also failed... Checked the OS version between this one and previously passing run, same OS, so should be no difference in the thread sanitizer version. Rerunning the previous passed workflow in another PR: https://github.com/intel/fpga-runtime-for-opencl/actions/runs/8071872741?pr=342

Reran the #342 previously passed workflow in thread sanitizer also failed, so this issue is not related to this PR. I don't know why this started to fail now. The image in the "ghcr.io/intel/fpga-runtime-for-opencl/ubuntu-22.04-dev:main" has not been updated for 2 months.

sophimao commented 8 months ago

The image in the "ghcr.io/intel/fpga-runtime-for-opencl/ubuntu-22.04-dev:main" has not been updated for 2 months.

Github actions seems to have updated their Ubuntu 22.04 image: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240310.1, could this be related?

zibaiwan commented 8 months ago

The image in the "ghcr.io/intel/fpga-runtime-for-opencl/ubuntu-22.04-dev:main" has not been updated for 2 months.

Github actions seems to have updated their Ubuntu 22.04 image: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240310.1, could this be related?

Thanks Sophie. Yes, this could be related. Although our image shouldn't have been updated since we built our image based on our custom docker file and store those in the "ghcr.io/intel/fpga-runtime-for-opencl/ubuntu-22.04-dev:main". Those custom images were built 2 months ago. However, maybe I don't know how github images work enough.

Maybe it still grabs the base Ubuntu image (which has the recent update) and then grab the delta changes from our custom image, then combine them to make a whole image, if this is the case, this will explain why this started to fail. I will continue investigating.

zibaiwan commented 8 months ago

I manually triggered a rebuild of all of our container images: https://github.com/intel/fpga-runtime-for-opencl/actions/runs/8329819821 here, maybe our custom image didn't play along with the new Ubuntu github image for some reason. Will test CI again after the rebuild.

zibaiwan commented 8 months ago

I manually triggered a rebuild of all of our container images: https://github.com/intel/fpga-runtime-for-opencl/actions/runs/8329819821 here, maybe our custom image didn't play along with the new Ubuntu github image for some reason. Will test CI again after the rebuild.

Nvm, manually triggered event doesn't update the registry due to the if guard in the work flow. Will revisit.

        if: github.event_name == 'push'
        run: docker image push "$image:$tag"
sophimao commented 8 months ago

Github actions updated their Ubuntu 22.04 image again to https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240317.1, which seems to resolve the thread sanitizer failure.