search

intel / gmmlib

Other
159 stars 87 forks source link

Fix overlapping comparison warning #79

Closed edwarddavidbaker closed 3 years ago

edwarddavidbaker commented 3 years ago

NumSamples can not be 8 and 16 at the same time. Closes #78.

warning: overlapping comparisons always evaluate to false [-Wtautological-overlap-compare]
Source/GmmLib/Texture/GmmGen9Texture.cpp:588:46:
           ((pTexInfo->MSAA.NumSamples == 8) && (pTexInfo->MSAA.NumSamples == 16)) &&
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
edwarddavidbaker commented 3 years ago

@johnmach Hi, could you take a look when you get a minute? Thanks.

edwarddavidbaker commented 3 years ago

Fixed in https://github.com/intel/gmmlib/commit/f1fa9eac06b92805f2f5670a9b2fbb923a557db6 .