search

intel / graph-compiler

MLIR-based toolkit targeting intel heterogeneous hardware
Apache License 2.0
32 stars 15 forks source link

Update llvm commit #357

Closed yifeizh2 closed 1 month ago

yifeizh2 commented 1 month ago

Update llvm commit to involve the fix for unpack op canonicalization and isaConvolutionOpInterface.

PR #101 requires this update to pass CI check.

Yun-Fly commented 1 month ago

Do we need to update llvm version of IMEX as well?

yifeizh2 commented 1 month ago

Do we need to update llvm version of IMEX as well?

Yes. Thanks for remindering.

Yun-Fly commented 1 month ago

Do we need to update llvm version of IMEX as well?

Yes. Thanks for remindering.

If so, please also raise a PR in this forked IMEX repo and request review of @dchigarev.

dchigarev commented 1 month ago

Do we need to update llvm version of IMEX as well?

Yes. Thanks for remindering.

If so, please also raise a PR in this forked IMEX repo and request review of @dchigarev.

Just to remind: we have a staging branch in the main imex repository, so all PRs should be submitted there.

One more thing: from our previous experience updating LLVM version for IMEX may not be that easy as simply updating llvm-commit hash. Given that GPU pipeline in GC works fine even with old LLVM for IMEX, we can leave it as it is for now and update it in a separate PR (if it would appear too complicated to make it now)

yifeizh2 commented 1 month ago

@dchigarev Hi. The current updated llvm commit has caused page fault runtime error in gpu mlp.mlir. The current error message is as follows

FATAL: Unexpected page fault from GPU at 0x7efc5a1f7000, ctx_id: 1 (CCS) type: 0 (NotPresent), level: 1 (PDE), access: 0 (Read), banned: 1, aborting.
^
<stdin>:1:8: note: possible intended match here
FATAL: Unexpected page fault from GPU at 0x7efc5a1f7000, ctx_id: 1 (CCS) type: 0 (NotPresent), level: 1 (PDE), access: 0 (Read), banned: 1, aborting.
       ^

The detailed CI log is accessible at: https://github.com/intel/graph-compiler/actions/runs/11043869278/job/30678842932?pr=357. Can you help troubleshoot this issue? Sorry for causing inconvenience.

dchigarev commented 1 month ago

Hi. The current updated llvm commit has caused page fault runtime error in gpu mlp.mlir. The current error message is as follows

The is-usm-args=false parameter for gpu pipeline was missing for some reason in mlp.mlir test. Committed fix to this branch

yifeizh2 commented 1 month ago

Hi. The current updated llvm commit has caused page fault runtime error in gpu mlp.mlir. The current error message is as follows

The is-usm-args=false parameter for gpu pipeline was missing for some reason in mlp.mlir test. Committed fix to this branch

Thanks a lot for help fixing this!