search

intel / gstreamer-media-SDK

GNU Lesser General Public License v2.1
90 stars 53 forks source link

Support for UYVY? History of WITH_MSS_2016? #117

Open pauldotknopf opened 6 years ago

pauldotknopf commented 6 years ago

Can somebody tell me the history of WITH_MSS_2016 define? I need to support UYVY and I don't know the implication of setting -DWITH_MSS_2016=false.

I'm running an Intel i7 6th gen. After enabling this feature, my application crashed with a SIGBUS. I'm thinking this might be the cause:

https://github.com/intel/gstreamer-media-SDK/blob/master/gst-libs/mfx/gstmfxsurface.c#L49

This isn't an Haswell system. Can I run -DWITH_MSS_2016=false on a standard Intel i7 6th/7th gen?

Also note, I'm using the new open source version media driver: https://github.com/intel/media-driver

ishmael1985 commented 6 years ago

The WITH_MSS_2016 define was meant to deal with a quirk with dealing with MFX surfaces in input system memory for with MSS 2016 Linux iHD driver, which is the last version of MSS which works for Haswell on Linux. Apparently an offset of 1 is needed to read those surfaces correctly especially for surfaces using packed color formats. It's a hack that was removed later on for gst-mfx, so by right you shouldn't have this compile macro enabled if you are not using MSS 2016 with Haswell. As for the crash, not really sure what causes it, but please let me know if it happens on my fork - https://github.com/ishmael1985/gstreamer-media-SDK or on the topic_linux_and_window branch.

ishmael1985 commented 6 years ago

@pauldotknopf can this be closed, or anything else you'd like to know?

pauldotknopf commented 6 years ago

My situation is solved by using your fork.

However the master branch here is still crashing with a SIGBUS error with that compiler option.

I guess it is up to the maintainers if they want to close it.

SiewHoon commented 6 years ago

In cmake build, the default -DWITH_MSS_2016=OFF. Are you build using meson? The WITH_MSS_2016 is turn on. It should be turn off by default. I will fix it. If you use fully open source media stack, It should not be need to turn on WITH_MSS_2016 anymore.