search

intel / gstreamer-media-SDK

GNU Lesser General Public License v2.1
90 stars 53 forks source link

Build fixes and logging of encoded frames #171

Closed uniemimu closed 5 years ago

uniemimu commented 5 years ago

Ref:

https://github.com/intel/gstreamer-media-SDK/issues/149 (although fix is limited to gstreamer-1.0 just like cmake is) https://github.com/intel/gstreamer-media-SDK/issues/148 https://github.com/intel/gstreamer-media-SDK/issues/146

ishmael1985 commented 5 years ago

@siewhoon perhaps if this passes the tests this could be merged?

SiewHoon commented 5 years ago

I will rejected this pull request. I will merge in "meson.build: set install_dir" patch.

eero-t commented 5 years ago

This "cmake, meson: build fixes" can not be accepted. The code fixed in meson.build that removed mfx_home, it will break build currently support in closed source MSDK library.

So basically you're saying that closed source MSDK is broken (doesn't support e.g. CI builds where each new build is done to a separate directory).

Why you prefer your build succeeding against that in open source Gstreamer plugin, instead of against the open source MSDK?

Could you add a link to a bug for the closed source MSDK, so that it can be tracked when they fix this? (It should be easy to fix, as they can take pkg-config support from the open source MSDK.)

SiewHoon commented 5 years ago

I didn't against Gstreamer plugin or MSDK library. I can't straight accept this solution and go broken the existing software support already shipped out. That patch didn't come out with a proper right solution.

Now I already fixed it. I will merge it after done code review.

Here is the code fixed and verify it: 0001-meson-build-fixed-find-mfx-dependecy-with-and-withou.patch.txt

eero-t commented 5 years ago

Yes, fallback to MFX_HOME in case MSDK isn't otherwise found is better.