intel / helm-charts

Apache License 2.0
12 stars 15 forks source link

Add DSA, IAA and DLB device plugins helm charts #14

Closed oxxenix closed 1 year ago

oxxenix commented 1 year ago

updated with node rules

mythi commented 1 year ago

@obaranov1 can you 'resolve' those comments that are addressed

oxxenix commented 1 year ago

@mythi ping

mythi commented 1 year ago

@mythi ping

sorry for the delay. I was going to merge but just noticed one more thing about the nodeFeatureRule default value. With that fixed, we can merge but that'll trigger 0.25.0 releases just for a subset of the plugins. Can you help to create a separate PR that moves the others to the same version (and makes the same updates than in this PR)?

mythi commented 1 year ago

@obaranov1 thanks for making the changes so quick. one last think: I think the kube-rbac-proxy update got dropped at some point https://github.com/intel/helm-charts/blob/658e406df14f6db4e1f375e232657b5e1f4c0a3c/charts/device-plugin-operator/templates/operator.yaml#L464 This PR used to have it.

tkatila commented 1 year ago

Not really related to this PR, but could you also fix the helm install/upgrade lines on device-plugin-operator README (https://github.com/intel/helm-charts/tree/main/charts/device-plugin-operator#install-helm-chart and https://github.com/intel/helm-charts/tree/main/charts/device-plugin-operator#upgrade-chart)?

The line is: helm install device-plugin-operator intel/device-plugin-operator [flags] But the working one is: helm install device-plugin-operator intel/intel-device-plugins-operator [flags]

oxxenix commented 1 year ago

@tkatila, @mythi, done

tkatila commented 1 year ago

@obaranov1 thanks, looks good!