intel / helm-charts

Apache License 2.0
12 stars 15 forks source link

In device-plugin-operator chart please add image.registry value for kube-rbac-proxy container #32

Closed MustDie95 closed 1 year ago

MustDie95 commented 1 year ago

In device-plugin-operator chart please add image.registry(or hub) value for kube-rbac-proxy container (like it is for manager container) to use with private registry. Instead of hard-coded "gcr.io/kubebuilder/kube-rbac-proxy"

mythi commented 1 year ago

makes sense. @obaranov1 would you be able to take this?

oxxenix commented 1 year ago

@mythi, ok

MustDie95 commented 1 year ago

I think the best way would be something like that:

privateRegistry:
  registryUrl: ~
  registryUser: ~
  registryPasswd: ~
  registrySecret: ~
{{- if .Values.privateRegistry.registrySecret }}
imagePullSecrets:
  - name: {{ .Values.privateRegistry.registrySecret }}
{{- end }}

...

{{- if .Values.privateRegistry.registryUrl }}
          image: "{{ .Values.privateRegistry.registryUrl }}/{{ .Values.image.repository }}:{{ .Values.image.tag }}"
{{- else }}
          image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
{{- end }}
{{- if .Values.privateRegistry.registrySecret }}
apiVersion: v1
kind: Secret
metadata:
  name: {{ .Values.privateRegistry.registrySecret }}
type: kubernetes.io/dockerconfigjson
data:
  .dockerconfigjson: {{\"auths\": {\"%s\": {\"auth\": \"%s\"}}}" .Values.privateRegistry.registryUrl (printf "%s:%s" .Values.privateRegistry.registryUser .Values.privateRegistry.registryPasswd | b64enc) | b64enc }}
{{- end }}