Closed oxxenix closed 9 months ago
@byako, @eero-t PTAL
According to your previous pull request in this repo (#43 ), a License file is needed in this chart ?
@tkatila, @poussa do we need to add licenses for all Intel helm charts?
According to your previous pull request in this repo (#43 ), a License file is needed in this chart ?
@tkatila, @poussa do we need to add licenses for all Intel helm charts?
Most of the charts do not have it. But I don't think it hurts to have it.
According to your previous pull request in this repo (#43 ), a License file is needed in this chart ?
@tkatila, @poussa do we need to add licenses for all Intel helm charts?
Most of the charts do not have it. But I don't think it hurts to have it.
thank you for a quick reply. I will include the licenses then.
Looks fine, but I wonder why YAML file contents are split differently from the project this is installing: https://github.com/intel/intel-resource-drivers-for-kubernetes/tree/main/deployments/
Here class + parameters, defaults, and daemonset+deployment are in same file, although in driver repo they are all 3 in separate YAML files. Whereas RBAC stuff is here in separate files but in driver repo in same file with deployments.
Wouldn't it be easier to check for changes and sync them, if k8s objects would be split similarly to separate files (and be in same order in them)?
Looks fine, but I wonder why YAML file contents are split differently from the project this is installing: https://github.com/intel/intel-resource-drivers-for-kubernetes/tree/main/deployments/
Here class + parameters, defaults, and daemonset+deployment are in same file, although in driver repo they are all 3 in separate YAML files. Whereas RBAC stuff is here in separate files but in driver repo in same file with deployments.
Wouldn't it be easier to check for changes and sync them, if k8s objects would be split similarly to separate files (and be in same order in them)?
I've been relying on the Helm chart available at dra-example-driver, which separates RBAC files and separately manages the deployments of the controller and kubelet-plugin.
I'm flexible and open to adapting to any upcoming changes. If the preference is to maintain all files individually, I'm ready to align with that approach.
I've been relying on the Helm chart available at dra-example-driver, which separates RBAC files and separately manages the deployments of the controller and kubelet-plugin.
I'm flexible and open to adapting to any upcoming changes. If the preference is to maintain all files individually, I'm ready to align with that approach.
I would think diffing / updating them would be easier if k8s objects in them are in same order and split to files with same names as in the original deployments for the driver it's installing. That could be separate PR though.
@byako, any comments on what you prefer?
I've been relying on the Helm chart available at dra-example-driver, which separates RBAC files and separately manages the deployments of the controller and kubelet-plugin. I'm flexible and open to adapting to any upcoming changes. If the preference is to maintain all files individually, I'm ready to align with that approach.
I would think diffing / updating them would be easier if k8s objects in them are in same order and split to files with same names as in the original deployments for the driver it's installing. That could be separate PR though.
@byako, any comments on what you prefer?
I made changes according to the request. Are we ready to merge? @eero-t, @byako
image: intel/intel-gpu-resource-driver:v0.2.0 crds files are added under crds folder