search

intel / helm-charts

Apache License 2.0
12 stars 15 forks source link

Update Intel GPU resource driver to v0.3.0 release #49

Closed oxxenix closed 7 months ago

oxxenix commented 7 months ago

@byako, @eero-t, PTAL

byako commented 7 months ago

Why was this closed so soon? What's the rush? Does this even work? Did we not need to bump the version in https://github.com/intel/helm-charts/blob/15ef5e948c396ca1f695e6298d402f6b085f8a11/charts/intel-gpu-resource-driver/values.yaml#L13 ? It will fail because v0.2.0 has old names. @oxxenix @eero-t what's going on, did anyone test this ?

eero-t commented 7 months ago

Did not test it, just checked that updates from driver 0.3.0 commit were there. I was assuming you to review and @oxxenix tests the Helm side, as I've not really used Helm myself.

(After CRD correction, I would assume test would fail if 0.2.0 binaries were used, as they would not match 0.3.0 CRDs...)