intel / intel-cmt-cat

User space software for Intel(R) Resource Director Technology
http://www.intel.com/content/www/us/en/architecture-and-technology/resource-director-technology.html
Other
693 stars 183 forks source link

pqos: Fix incorrect LLC misses output #154

Closed xiaochenshen closed 4 years ago

xiaochenshen commented 4 years ago

pqos: Fix incorrect LLC misses output

Regression issue caused by 1da37998bf5c ("pqos: Added options to disable IPC and LLC misses monitoring").

Fix https://github.com/intel/intel-cmt-cat/issues/153

Description

Fix two issues in LLC misses monitoring in pqos:

  1. pqos: Fix a typo in LLC misses monitoring
  2. pqos: Fix incorrect LLC misses output due to type casting

Affected parts

Motivation and Context

Regression issue caused by 1da37998bf5c ("pqos: Added options to disable IPC and LLC misses monitoring").

Fix https://github.com/intel/intel-cmt-cat/issues/153

How Has This Been Tested?

$ pqos
$ pqos -o tmp.xml -u xml
$ pqos -o tmp.csv -u csv

Without the fix:

    CORE         IPC      MISSES     LLC[KB]   MBL[MB/s]   MBR[MB/s]
       0        0.69  333562573k       264.0         0.3         0.0
       1        0.27  333562573k        88.0         0.0         0.0
       2        0.26  333562573k       176.0         0.2         0.0
       3        0.09  333562573k         0.0         0.0         0.0
       4        0.10  333562573k         0.0         0.0         0.0
       5        0.27  333562573k         0.0         0.0         0.0
       6        2.15  333562573k         0.0         0.0         0.0
       7        0.42  333562573k         0.0         0.0         0.0
       8        0.54  333562573k         0.0         0.0         0.0
       9        0.09  333562573k        88.0         0.0         0.0
      10        0.15  333562573k       176.0         0.0         0.1
      11        0.11  333562573k         0.0         0.0         0.0
      12        0.13  333562573k         0.0         0.0         0.0
      13        0.17  333562573k         0.0         0.0         0.0
      14        0.17  333562573k         0.0         0.1         0.0
      15        0.19  333562573k        88.0         0.1         0.0
      16        0.08  333562573k         0.0         0.0         0.0

With the fix:

    CORE         IPC      MISSES     LLC[KB]   MBL[MB/s]   MBR[MB/s]
       0        0.91        390k       616.0         0.0         0.0
       1        0.22        157k         0.0         0.0         0.0
       2        0.55        156k        88.0         0.0         0.0
       3        0.12        104k        88.0         0.0         0.0
       4        0.11        344k         0.0         0.0         0.0
       5        0.27        177k         0.0         0.0         0.0
       6        1.71        404k         0.0         0.0         0.0
       7        0.59        532k        88.0         0.0         0.0
       8        0.72        327k         0.0         0.0         0.0
       9        0.14         89k        88.0         0.0         0.0
      10        0.33        168k         0.0         0.0         0.0
      11        0.13        140k        88.0         0.0         0.0
      12        0.18        134k         0.0         0.0         0.0
      13        0.33        146k       968.0         0.0         0.0
      14        0.12        132k       176.0         0.0         0.0
      15        0.31        162k      2376.0         0.0         0.0
      16        0.12        159k       176.0         0.0         0.0

Types of changes

Checklist:

wandralx commented 4 years ago

Merged.