`make SHARED=n` fails for v4.0

tkanteck commented 3 years ago

cc -L../lib -pie -z noexecstack -z relro -z now alloc.o cap.o common.o main.o monitor.o profiles.o -lpqos -lpthread -o pqos
/usr/bin/ld: ../lib/libpqos.a(common.o): in function `pqos_fopen':
/home/tkanteck/src/intel-cmt-cat-4.0/lib/common.c:45: multiple definition of `pqos_fopen'; common.o:/home/tkanteck/src/intel-cmt-cat-4.0/pqos/common.c:44: first defined here
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:98: pqos] Error 1
make[1]: Leaving directory '/home/tkanteck/src/intel-cmt-cat-4.0/pqos'
make: *** [Makefile:54: all] Error 2

kmabbasi commented 3 years ago

This issue has already been resolved!

Thanks, Khawar

ColinIanKing commented 3 years ago

FYI, the fix was:

commit 850e4edff5795c6b564e84fc27b61134ed8ff3c2 (HEAD, refs/bisect/bad) Author: Boczkowski, AdrianX adrianx.boczkowski@intel.com Date: Fri Jul 3 11:54:00 2020 +0100

pqos: rename safe wrappers for opening a file

intel / intel-cmt-cat

`make SHARED=n` fails for v4.0 #173