Mba fixes v2

[babumoger]

Few fixes.

1. MBA feature was broken for AMD
2. Changed printing messages from SOCKET to Core Complex for AMD
3. pqos reset fix.
4. Addressed the comments from Michał Aleksiński for my earlier pull request.

Description

1. The MBA feature was not working when trying to set the MBA limits on AMD. pqos -I OS -e mba:1=0xf NOTE: Mixed use of MSR and kernel interfaces to manage CAT or CMT & MBM may lead to unexpected behavior. ERROR: Expected MBA controller but not requested! SOCKET 0 MBA COS1 - FAILED! Allocation configuration error! The code was using the hard coded value to detect the feature. Changed it to use the vendor specific mba_max values while detecting the feature.

2. Also fixed printing messages on AMD Before the change. SOCKET 0 MBA COS1 => 256% requested, 256% applied SOCKET 1 MBA COS1 => 256% requested, 256% applied SOCKET 2 MBA COS1 => 256% requested, 256% applied SOCKET 3 MBA COS1 => 256% requested, 256% applied

After the change.

Core Complex 0 MBA COS1 => 256 requested, 256 applied Core Complex 1 MBA COS1 => 256 requested, 256 applied Core Complex 2 MBA COS1 => 256 requested, 256 applied Core Complex 3 MBA COS1 => 256 requested, 256 applied

3. F ix hard-coded MBA reset value pqos -I OS -R This was resetting the COS values to 100 on AMD systems. Changed it to reset based on vendor.

Affected parts

• [x ] library
• [x ] pqos utility
• [ ] rdtset utility
• [ ] other: (please specify)

Motivation and Context

Without this fix MBA feature wont work on AMD.

How Has This Been Tested?

Tested on AMD system and sanity tested old intel machine.

Types of changes

• [x ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• [ x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.

[babumoger]

Let me know if there are any comments. Thanks

[aleksinx]

Changes from this pull request have been merged into master

[babumoger]

Thanks Closing the pull request.