Running static analysis with clang's scan-build found a couple of issues, one set related to incorrect use of strncpy that can be easily fixed with strncpy and another issue with a redundant initialization of a variable (minor code clean-up). I generally run static analysis on code that I package for Debian to ensure it's as bug free as possible.
Tested on a Numa Intel camelback 12 core SDP box with ubuntu 22.04 - ran pqos.
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
Running static analysis with clang's scan-build found a couple of issues, one set related to incorrect use of strncpy that can be easily fixed with strncpy and another issue with a redundant initialization of a variable (minor code clean-up). I generally run static analysis on code that I package for Debian to ensure it's as bug free as possible.
Tested on a Numa Intel camelback 12 core SDP box with ubuntu 22.04 - ran pqos.
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.