pqos: alloc: remove redundant null check on pointer ids

[ColinIanKing]

The pointer ids is being redundantly null checked in a few places, ids has already been null checked in earlier return paths. Note that null checking on a free of null is also redundant since free won't attempt to free a null pointer.

Cleans up static analysis warning from cppcheck: Checking pqos/alloc.c ... pqos/alloc.c:482:44: style: Condition 'ids!=NULL' is always true [knownConditionTrueFalse] if (res_ids == NULL && ids != NULL) ^ pqos/alloc.c:496:44: style: Condition 'ids!=NULL' is always true [knownConditionTrueFalse] if (res_ids == NULL && ids != NULL) ^ pqos/alloc.c:508:36: style: Condition 'ids!=NULL' is always true [knownConditionTrueFalse] if (res_ids == NULL && ids != NULL)

Signed-off-by: Colin Ian King colin.i.king@gmail.com

Description

Affected parts

• [ ] library
• [x] pqos utility
• [ ] rdtset utility
• [ ] App QoS
• [ ] other: (please specify)

Motivation and Context

• Cleans up cppcheck static analysis warnings, redundant null checks will be compiled out so we may as well remove them in the C source too.

How Has This Been Tested?

• Just build tested and double-checked with static analysis re-build

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.