search

intel / intel-graphics-compiler

Other
606 stars 158 forks source link

Fix build with LLVM 12 #171

Closed zboszor closed 3 years ago

zboszor commented 3 years ago

Signed-off-by: Zoltán Böszörményi zboszor@gmail.com

pszymich commented 3 years ago

The commit is being delayed by problems with internal verification. I will update this PR with necessary changes when I get it resolved.

lin7sh commented 3 years ago

LLVM 12 officially released yesterday, any progress on this?

thiagomacieira commented 3 years ago

ping. What's taking time to even provide feedback?

pszymich commented 3 years ago

Hello,

@thiagomacieira, the delay with handling this PR was unfortunately caused by dropping LLVM11/12 upgrade priority internally, which I'm back to working on.

@zboszor, your pull-request is now merged, although I had to tweak a couple things, mainly the removed passes and merge conflicts, as well as some small additions like explicit casts to avoid error-on-warning buildbreaks. You can find the commit here: https://github.com/intel/intel-graphics-compiler/commit/4bc6b443a545706b384b750533b5838c1d7251c1 As all pull-requests in this repository, they have to go through our internal workflow. This is why the PR is not merged directly. If you have any questions or concerns regarding this commit please contact me.

Thank you for your contribution!

foutrelis commented 3 years ago

Shouldn't this be reopened since it was backed out by 32944e60e97f634fe975b9407e1f1d6b6510f93b?

ArchangeGabriel commented 3 years ago

More generally, can we get insight on what is happening? The patch was commited and reverted twice… https://github.com/intel/intel-graphics-compiler/commit/4bc6b443a545706b384b750533b5838c1d7251c1 https://github.com/intel/intel-graphics-compiler/commit/bcda9e4e7bccbd3351feb7814daae468c5db504f https://github.com/intel/intel-graphics-compiler/commit/1c28c742daac3e2d2a3188716d913dd515f18acb https://github.com/intel/intel-graphics-compiler/commit/32944e60e97f634fe975b9407e1f1d6b6510f93b