search

intel / intel-graphics-compiler

Other
605 stars 158 forks source link

Changes in FindSPIRVLLVMTranslator.cmake fail build on Linux with external spirv-llvm-translator #243

Closed ArchangeGabriel closed 2 years ago

ArchangeGabriel commented 2 years ago

These changes were introduced by https://github.com/intel/intel-graphics-compiler/commit/afd9fc8be5e507ccfd24d1e5b4da4d2e05c671ff.

It now seems to look for some debug version that we don’t have, at least on Arch Linux. Please either tell us how to achieve such a build or make this change Windows only (as this seems the reason for the change) or somehow accepting both configurations.

mnaczk commented 2 years ago

Hi, Thanks for submitting the issue. This should be resolved by commit https://github.com/intel/intel-graphics-compiler/commit/991fd3d661efcb4fb6df63b76310d6e634b05c39 (https://github.com/intel/intel-graphics-compiler/commit/afd9fc8be5e507ccfd24d1e5b4da4d2e05c671ff modified to be Windows only).

Please inform us if the issue still exists after https://github.com/intel/intel-graphics-compiler/commit/991fd3d661efcb4fb6df63b76310d6e634b05c39

ArchangeGabriel commented 2 years ago

Hi, I indeed catched that commit since I was surprised people could build from git master y-day. ^^

I can thus confirm it perfectly works, both in master as well as on top of the current release.

I think this ticket should remain open until the commit is part of a release to avoid duplicate tickets from other users/packagers.

eero-t commented 2 years ago

There was "igc-1.0.11279" release few hours ago, but unfortunately that's from commit on 11th, while the fix went in on 13th. So I guess it's in the next release.

(This issue was added as last commit to "igc-1.0.11222" release on 4th.)

eero-t commented 2 years ago

@ArchangeGabriel Could you add also the lld issue to the title so that people find easier what was broken, and that above mentioned commit fixes both ("Fix finding lldelf and SpirvLLVMTranslator")?

eero-t commented 2 years ago

@ArchangeGabriel I think you can close this. Fix is included to latest "igc-1.0.11378" release and it builds fine for me.