Latest "igc-1.0.11485" release does not build (regression from previous release)

[eero-t]

Setup / deps

• Ubuntu 21.10:
  • LLVM 12
  • opencl-clang 12.0.0
  • llvm-spirv 12.0.0
  • GCC 11.2
• GMMlib:
  • intel-gmmlib-22.1.6
• SPIRV Headers / Tools:
  • sdk-1.3.211.0 (or sdk-1.3.216.0)
• vc-intrinsics:
  • v0.4.2 (or v0.5.0)

Build error

Previous IGC release (igc-1.0.11378) builds fine with this setup, latest (igc-1.0.11485) release fails at config stage to:

cmake -LH -Wno-dev -G Ninja       -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}       -DCMAKE_BUILD_TYPE=Release       -DIGC_OPTION__LLVM_PREFERRED_VERSION=12
...
-- The C compiler identification is GNU 11.2.0
-- The CXX compiler identification is GNU 11.2.0
...
-- Advanced:
--  - Link BiF resources:              ON
--  - Building Windows Universal:      
...
-- =============================================================================
-- [IGC] : opencl-clang will be taken from system
-- [IGC] Found clang-12 executable: /usr/bin/clang-12
-- [CMFE] CM Frontend headers are taken from: /home/nobody/source/intel-graphics-compiler/IGC/CMFE/AdaptorCM
-- [CMFE] Using CMFE library name: libclangFEWrapper.so
-- +++ Source/IGC/VectorCompiler +++
-- [VC] Build proj: VectorCompiler
-- [VC] Using vc-intrinsics source from: /home/nobody/source/intel-graphics-compiler/IGC/VectorCompiler/../../../vc-intrinsics/GenXIntrinsics
>>/home/nobody/source/intel-graphics-compiler/build/IGC/VectorCompiler/lib/GenXCodeGen/Utils/../<<  ->  /home/nobody/source/intel-graphics-compiler/build/IGC/VectorCompiler/lib/GenXCodeGen/Utils
 COMMAND ->  /usr/bin/python3 /home/nobody/source/intel-graphics-compiler/IGC/VectorCompiler/lib/GenXCodeGen/Utils/cisa_gen_intrinsics.py /home/nobody/source/intel-graphics-compiler/IGC/VectorCompiler/lib/GenXCodeGen/Utils/cisa_gen_intrinsics.json /home/nobody/source/intel-graphics-compiler/build/IGC/VectorCompiler/lib/GenXCodeGen/Utils/../ <-
 /home/nobody/source/intel-graphics-compiler/IGC/VectorCompiler/lib/GenXCodeGen/Utils
mvc_build_bif - VCBiFPrintfOCL32 has extra dependencies: /home/nobody/source/intel-graphics-compiler/IGC/VectorCompiler/lib/BiF/printf_not_cm_common.h
mvc_build_bif - VCBiFPrintfOCL64 has extra dependencies: /home/nobody/source/intel-graphics-compiler/IGC/VectorCompiler/lib/BiF/printf_not_cm_common.h
mvc_build_bif - VCBiFPrintfZE32 has extra dependencies: /home/nobody/source/intel-graphics-compiler/IGC/VectorCompiler/lib/BiF/printf_not_cm_common.h
mvc_build_bif - VCBiFPrintfZE64 has extra dependencies: /home/nobody/source/intel-graphics-compiler/IGC/VectorCompiler/lib/BiF/printf_not_cm_common.h
Use InstCombiner from LLVM
IGC\BiFModuleCache] - IGC_BUILD__BIF_ROOT_DIR: /home/nobody/source/intel-graphics-compiler/build/IGC/Release/bif/
CMake Error at IGC/BiFModule/cmake/BiFModuleCache.cmake:17 (get_bif_src_list):
  get_bif_src_list Function invoked with incorrect arguments for function
  named: get_bif_src_list
Call Stack (most recent call first):
  IGC/BiFModule/CMakeLists.txt:15 (include)

[IGC\BiFModuleCache] - BiFModule_SRC: /home/nobody/source/intel-graphics-compiler/IGC/BiFModule/cmake/../

With the previous (working) release, everything after "Use InstCombiner from LLVM" is missing from the build log.

PS. I'm intentionally testing latest available source releases, while using distro packages for as many deps as possible. I realize LLVM 12 support is beta, and only LLVM 11 is production, but I think at least building should work for beta support.

Note: I'll test next 22.04 LTS / LLVM 13 (which did not work earlier), as 21.10 EOLed last week: https://wiki.ubuntu.com/Releases

If LLVM 13 works, and you are in process of dropping LLVM 12 support completely, that's fine with me as latest Ubuntu LTS defaults LLVM 13, while current Debian stable defaults to LLVM 11 and next one to LLVM 13. I have no idea whether some RPM based distros with LTS / stable versions, default to LLVM 12 though.

[pszymich]

Hi, I believe it's a duplicate of #248. The fix is most likely to get intercepted with the next release. Can you confirm the suggested cherry-pick from #248 fixes your issue?

[eero-t]

Yes, cherry-picking that solves the issue => closing.

Thanks, and sorry for not checking the already solved tickets list first!