intel / intel-graphics-compiler

Other
594 stars 155 forks source link

Enhance Local Dataflow Handling and Analysis #301

Open lab596 opened 1 year ago

lab596 commented 1 year ago

In the file visa/LocalDataflow.h, there's a TODO statement that suggests improving the handling of Local Dataflow and turning it into a class. The TODO also mentions an assumption about escaped instructions and a potential change from a map to a vector or set. I was wondering if the implementation of this is complete yet.

TODO Statement:

Line19: // ToDo: move Local dataflow here and make it a class

Line 39: // If BB is not in the map, it means we need to run analysis for this BB
  // ToDo: assumption is that there should not be many escaped inst. Can change
  // to vector to set later if desired.

It would be beneficial to address this TODO by implementing the proposed changes. By moving Local Dataflow into a class and optimizing the analysis process, we can potentially improve the efficiency and maintainability of the code.

I do not have the coding knowledge to implement this change, but I would love to learn. Any advice is appreciated.