search

intel / intel-iot-refkit

MIT License
35 stars 61 forks source link

meta-iotqa: upsquared.mask #324

Closed playwithreality closed 6 years ago

playwithreality commented 6 years ago

Ignores tests for UP Squared that cannot be run on it.

Jenkins uses mask files to determine the DAFT tests that are to be excluded for each supported board. UP Squared doesn't have Bluetooth and WIFI so it makes sense to exclude these tests to avoid unnecessary error notifications which would appear with every pull request test.

Signed-off-by: Sami Nieminen sami1.nieminen@intel.com

playwithreality commented 6 years ago

Test still needs to be run on upsquared device to ensure it is working as intended.

mythi commented 6 years ago

@samniem please add the reasoning why they need to be masked in the commit message

playwithreality commented 6 years ago

@mythi Added reasoning

mythi commented 6 years ago

@samniem the commit is not updated

mythi commented 6 years ago

@samniem to update the PR commit, you'd have to force push to your remote branch. There's no need to close the PR. If you're still planning to submit the change, you can reopen this PR and do the force push (the order is important)

playwithreality commented 6 years ago

@mythi at the moment the pull request has to wait, as mraa and upm libraries need to be upgraded for UP Squared to work properly. UP Squared mask could be added to the same PR with these updates to make a neat package for UP Squared. New intel-iot-devkit upm version is failing with bitbake at the moment so I'm figuring out what is causing this.