intel / intel-ipsec-mb

Intel(R) Multi-Buffer Crypto for IPSec
BSD 3-Clause "New" or "Revised" License
288 stars 88 forks source link

test: [snow3g] add random vectors and new linear tests #105

Closed julienmeunier closed 2 years ago

julienmeunier commented 2 years ago

Description

In order to cover the bug #104 (AVX2 implementation issue), new random vectors and testcases are added. Without the fix provided in #104, these testcases failed with the AVX2 implementation.

New testcases

New test vectors

Affected parts

Motivation and Context

Test covering #104

How Has This Been Tested?

Tested with an Intel(R) Xeon(R) CPU E5-2680 v4 (AVX2 support)

Types of changes

Checklist:

tkanteck commented 2 years ago

Thanks Julien!

I suppose there is a typo in the 2nd line of the description and with this particular commit test passes, right?

without the commit https://github.com/intel/intel-ipsec-mb/commit/30cb6df2b04d69a224a5fcd3bb9f0c0c1a01fc91, snow3g test failed with the commit https://github.com/intel/intel-ipsec-mb/commit/30cb6df2b04d69a224a5fcd3bb9f0c0c1a01fc91, snow3g test failed

julienmeunier commented 2 years ago

Thanks Julien!

I suppose there is a typo in the 2nd line of the description and with this particular commit test passes, right?

without the commit 30cb6df, snow3g test failed with the commit 30cb6df, snow3g test failed

Ah yes, wrong copy paste... I will update the description.

tkanteck commented 2 years ago

Thank you. Looks good and it covers required extended testing.

tkanteck commented 2 years ago

thanks! it is merged in https://github.com/intel/intel-ipsec-mb/commit/2f7118523937c77ed5f9977f1987f1a5f4dc834e