intel / intel-ipsec-mb

Intel(R) Multi-Buffer Crypto for IPSec
https://intel.github.io/intel-ipsec-mb/
BSD 3-Clause "New" or "Revised" License
299 stars 90 forks source link

Update of minimum NASM version from 2.14 to 2.16 #117

Open tkanteck opened 1 year ago

tkanteck commented 1 year ago

For the time being, build system has been updated to work with NASM 2.14 and 2.16 producing different binaries and delivering different performance levels on some hardware platforms.

Going forward, in order to produce binary with consistent performance and use required instructions it will be necessary to change minimum required NASM version from 2.14 to NASM 2.16

tkanteck commented 7 months ago

The next release will require NASM 2.16.02

If there are any potential problems with it then please let us know here

riveridea commented 1 month ago

Can I know what could be impacted if my NASM is 2.15.3 while I see this warning: NASM 'nasm' version: 2.15.03 Makefile:102: Minimum required NASM version for AVX-IFMA: 2.16. AVX-IFMA code not compiled - update NASM.

tkanteck commented 1 month ago

AVX-IFMA is only used for POLY1305 in the library. There is only performance impact. AVX-IFMA based POLY1305 implementation is faster. There is no impact as long as: