intel / intel-ipsec-mb

Intel(R) Multi-Buffer Crypto for IPSec
BSD 3-Clause "New" or "Revised" License
288 stars 88 forks source link

cmake clenups. #138

Closed kloczek closed 6 months ago

kloczek commented 7 months ago

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

diizzyy commented 7 months ago

You probably want to use MANDIR instead of hardcoding it https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html#module:GNUInstallDirs

kloczek commented 7 months ago

Yes but that is better than nothing 😋

diizzyy commented 7 months ago

Please update your PR it to use ${CMAKE_INSTALL_MANDIR} then :-)

mdcornu commented 7 months ago

You probably want to use MANDIR instead of hardcoding it https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html#module:GNUInstallDirs

Is there any plan to add this in this PR?

mdcornu commented 6 months ago

This has been merged in b0d25b8f04d99229dd616a4afe59e1e91f689b4b and d1ff02c90449ba2046e9d0491244fbf7fabc822f. Thank you for your contribution.

kloczek commented 6 months ago

Thank you