search

intel / intel-ipsec-mb

Intel(R) Multi-Buffer Crypto for IPSec
BSD 3-Clause "New" or "Revised" License
289 stars 87 forks source link

added addon-(cipher,hash) algorithm #14

Closed deadcafe closed 7 years ago

deadcafe commented 7 years ago 
    Supports addition of optional CIPHER and HASH algorithms in NOCHECK mode.
    As a result, 3DES, CHACHA20-POLY1305, etc. can also be used with MB API.
tkanteck commented 7 years ago

I like the idea and the only thing that I miss here is the test code for this feature. Please add some test code for it. Another comment is that it could be more flexible to define custom cipher / hash per job and not per MB_MGR. I would probably prefer the per job option. Are there any cons of having these defined per job?

tkanteck commented 7 years ago

Thanks for prompt patch update! Could you have a look into following changes, please?