Possible regression: init_mb_mgr_avx() corrupts state on Windows

intel / intel-ipsec-mb

Intel(R) Multi-Buffer Crypto for IPSec

BSD 3-Clause "New" or "Revised" License

292 stars 88 forks source link

Closed dawid-sabat closed 5 months ago

dawid-sabat commented 5 months ago

@tkanteck we see this issue #115 again after we updated our intel-ipsec-mb to v1.5.

Going through the code I see there was a major refactor there. Could you investigate? Looks like a regression.

tkanteck commented 5 months ago

thanks - I'll have a look into it

tkanteck commented 5 months ago

Many thanks for your help in hunting it down!

It is not exactly the same but similar in nature. SIMD register not restored on Windows.

sha256_ni_block_sse doesn't preserve xmm7 register and this is used for IPAD/OPAD calculations on platforms with SHANI. This code is executed as part of the self-test.

thiagomacieira commented 5 months ago

Do you have a patch?

tkanteck commented 5 months ago

The fix is merged now. Thanks!