search

intel / intel-ipsec-mb

Intel(R) Multi-Buffer Crypto for IPSec
BSD 3-Clause "New" or "Revised" License
289 stars 87 forks source link

Fix ctr #3

Closed deadcafe closed 7 years ago

tkanteck commented 7 years ago

new file 'ctr_test.c' is missing a copyright/license header. Could you copy-paste proper header for the file here? I can add it in the process of merging. If you prefer to re-submit the whole patch then I am OK with it, too. Thanks, Tomasz

deadcafe commented 7 years ago

added copyright, and fixed a bit.

deadcafe commented 7 years ago

done, rebase master

tkanteck commented 7 years ago

thanks I'll look into it soon

tkanteck commented 7 years ago

Hi Deadcafe, the changes were just merged in f4ed204ccf1432e29bfff0938585748245f5be0a. There is a few differences vs the original pull request: (1) small assembly code restructure and use of memcpy macros for the partial block (no loads/stores beyond buffer) (2) tests code restructure for clarity (3) job valid check only changed to allow non-block sizes for CTR. The other changes allowed for more ways to use NULL_HASH and NULL_CIPHER modes which are not recommended (4) Test code modified to compile & run on Windows Thanks, Tomasz