intel / intel-ipsec-mb

Intel(R) Multi-Buffer Crypto for IPSec
BSD 3-Clause "New" or "Revised" License
289 stars 87 forks source link

disable stack execution flag in zuc_common.asm #38

Closed ColinIanKing closed 5 years ago

ColinIanKing commented 5 years ago

The stack execution flag in zuc_common.o should be disabled. Note, these issues can be checked using 'scanelf -qeR .' and check for !WX in the first column.

Signed-off-by: Colin Ian King colin.king@canonical.com

Description

Without this fix, the final shared library has an executable stack which is a potential security issue. This fix is similar to one I fixed with commit:

commit 9ca9a5c0f45a2e257410714708041a972d1f407f Author: Colin Ian King colin.king@canonical.com Date: Tue Jul 3 10:12:04 2018 +0100

disable stack execution flag in const.asm

Affected parts

Motivation and Context

The shared library has a executable stack as detected during a sanity check of the Debian package:

W: libipsec-mb0: shlib-with-executable-stack usr/lib/x86_64-linux-gnu/libIPSec_MB.so.0.51

How Has This Been Tested?

No. Only build tested.

Types of changes

Checklist:

tkanteck commented 5 years ago

Thanks Colin! The patch has been merged https://github.com/intel/intel-ipsec-mb/commit/e1ea1c4c5cbf74f1db80992b5eaf20ecbfd8dbb7