option to build library in other directory

intel / intel-ipsec-mb

Intel(R) Multi-Buffer Crypto for IPSec

BSD 3-Clause "New" or "Revised" License

289 stars 87 forks source link

option to build library in other directory #39

Closed Jean-Mick closed 4 years ago

Jean-Mick commented 4 years ago

Description

The changes include minor fixes and move the build of library inside obj directory.

Affected parts

[ x] Library
[ x] LibTestApp
[ x] LibPerfApp
[ ] Other: (please specify)

Motivation and Context

This allows multiple builds with different options (e.g. SHARED) from the same source directory.

How Has This Been Tested?

Tested with git status, make clean, make, make install, with SHARED=y and SHARED=n

Not tested on Windows.

Types of changes

[ x] Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

tkanteck commented 4 years ago

Hello Jean-Mick, Many thanks for your pull request. I am guessing that in for some reason you need to put output files in one location (obj folder). However, such change would create domino effect for us to update some internal validation tool-chain. Would it be reasonable to have LIBRARY_OUTPUT_LOCATION make environment setting to default to currently used location? This will also give ability to change it, to 'obj' folder, if required. Thanks, Tomasz

Jean-Mick commented 4 years ago

Hello Tomasz,

OK I'm fine with LIBRARY_OUTPUT_LOCATION, I see the backward compat issue with existing tool.

Thanks, Jean-Mickael

tkanteck commented 4 years ago

Hi Jean-Mickael, Do you see backward compatibility issue with the library? Could you explain more? Thanks, Tomasz

Jean-Mick commented 4 years ago

No, I just refer to the issue you mentioned wrt validation tools looking for current location.

tkanteck commented 4 years ago

Ahh :) sorry, travelling made me bit slow. Thanks for the explanation. OK, could you change the default location in the pull request then? Other then this it looks good for merging. Thanks again!

Jean-Mick commented 4 years ago

No problem :-) Yes I will rework the patch to do that.

tkanteck commented 4 years ago

Thanks a mil! The patches have been just merged.