Closed Jean-Mick closed 4 years ago
Hello Jean-Mick, Many thanks for your pull request. I am guessing that in for some reason you need to put output files in one location (obj folder). However, such change would create domino effect for us to update some internal validation tool-chain. Would it be reasonable to have LIBRARY_OUTPUT_LOCATION make environment setting to default to currently used location? This will also give ability to change it, to 'obj' folder, if required. Thanks, Tomasz
Hello Tomasz,
OK I'm fine with LIBRARY_OUTPUT_LOCATION, I see the backward compat issue with existing tool.
Thanks, Jean-Mickael
Hi Jean-Mickael, Do you see backward compatibility issue with the library? Could you explain more? Thanks, Tomasz
No, I just refer to the issue you mentioned wrt validation tools looking for current location.
Ahh :) sorry, travelling made me bit slow. Thanks for the explanation. OK, could you change the default location in the pull request then? Other then this it looks good for merging. Thanks again!
No problem :-) Yes I will rework the patch to do that.
Thanks a mil! The patches have been just merged.
Description
The changes include minor fixes and move the build of library inside obj directory.
Affected parts
Motivation and Context
This allows multiple builds with different options (e.g. SHARED) from the same source directory.
How Has This Been Tested?
Tested with git status, make clean, make, make install, with SHARED=y and SHARED=n
Not tested on Windows.
Types of changes
Checklist: