search

intel / intel-vaapi-driver

VA-API user mode driver for Intel GEN Graphics family
https://01.org/linuxmedia
Other
308 stars 127 forks source link

when compiling master without libva master compilation fails #341

Open ceyusa opened 6 years ago

ceyusa commented 6 years ago

Error log:

gen7_mfd.c: In function ‘gen7_mfd_vc1_decode_init’:
gen7_mfd.c:1401:30: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘intensity_compensation_field’
                 if (pic_param->intensity_compensation_field == 1 || /* Top field */
                              ^~
gen7_mfd.c:1402:30: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘intensity_compensation_field’
                     pic_param->intensity_compensation_field == 0) { /* Both fields */
                              ^~ 
gen7_mfd.c:1436:30: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘intensity_compensation_field’
                 if (pic_param->intensity_compensation_field == 2 || /* Bottom field */
                              ^~
gen7_mfd.c:1437:30: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘intensity_compensation_field’
                     pic_param->intensity_compensation_field == 0) { /* Both fields */
                              ^~
gen7_mfd.c:1445:46: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘intensity_compensation_field’
                                 if (pic_param->intensity_compensation_field == 2) { /* Bottom field */
                                              ^~
gen7_mfd.c:1449:97: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘luma_scale2’; did you mean ‘luma_scale’?
                                     gen7_vc1_forward_surface->luma_scale_bottom[i] = pic_param->luma_scale2;
                                                                                                 ^~~~~~~~~~~
                                                                                                 luma_scale
gen7_mfd.c:1450:97: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘luma_shift2’; did you mean ‘luma_shift’?
                                     gen7_vc1_forward_surface->luma_shift_bottom[i] = pic_param->luma_shift2;
                                                                                                 ^~~~~~~~~~~
                                                                                                 luma_shift
gen7_mfd.c:1461:50: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘intensity_compensation_field’
                                     if (pic_param->intensity_compensation_field == 2) { /* Bottom field */
                                                  ^~
gen7_mfd.c:1465:101: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘luma_scale2’; did you mean ‘luma_scale’?
                                         gen7_vc1_forward_surface->luma_scale_bottom[i] = pic_param->luma_scale2;
                                                                                                     ^~~~~~~~~~~
                                                                                                     luma_scale
gen7_mfd.c:1466:101: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘luma_shift2’; did you mean ‘luma_shift’?
                                         gen7_vc1_forward_surface->luma_shift_bottom[i] = pic_param->luma_shift2;
                                                                                                     ^~~~~~~~~~~
                                                                                                     luma_shift
gen7_mfd.c:1475:45: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘intensity_compensation_field’
                                if (pic_param->intensity_compensation_field == 2) { /* Bottom field */
                                             ^~
gen7_mfd.c:1479:97: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘luma_scale2’; did you mean ‘luma_scale’?
                                     gen7_vc1_current_surface->luma_scale_bottom[i] = pic_param->luma_scale2;
                                                                                                 ^~~~~~~~~~~
                                                                                                 luma_scale
gen7_mfd.c:1480:97: error: ‘VAPictureParameterBufferVC1 {aka struct _VAPictureParameterBufferVC1}’ has no member named ‘luma_shift2’; did you mean ‘luma_shift’?
                                     gen7_vc1_current_surface->luma_shift_bottom[i] = pic_param->luma_shift2;
                                                                                                 ^~~~~~~~~~~
                                                                                                 luma_shift

In my opinion, it is required to bump the VA-API version because this libva's commit changed the API

commit 992227debe1b5e25da53b2606b4f67c46eb7ad46 Author: carpalis <> Date: Thu Nov 16 20:38:34 2017 +0100

Add fields for intensity compensation in VC-1 interlaced decoding

what do you thing?

this seems to be a libva issue, but it is reflected with the driver.

xhaihao commented 6 years ago

Yes, we will bump the VA-API version.