i965_avc_encoder.c:6583:42: warning: duplicated 'if' condition

intel / intel-vaapi-driver

VA-API user mode driver for Intel GEN Graphics family

https://01.org/linuxmedia

Other

308 stars 125 forks source link

i965_avc_encoder.c:6583:42: warning: duplicated 'if' condition #540

Open dcb314 opened 3 years ago

dcb314 commented 3 years ago

gcc compiler with flag -Wduplicated-cond says

i965_avc_encoder.c:6583:42: warning: duplicated 'if' condition [-Wduplicated-cond] 6583 | } else if (generic_state->frame_type == SLICE_TYPE_P) { / B slice / i965_avc_encoder.c:6571:42: note: previously used here 6571 | } else if (generic_state->frame_type == SLICE_TYPE_P) {

yumkam commented 2 years ago

Looks like a bug and that should've been SLICE_TYPE_B; I guess it should affect AVC encoding on Gen9 gpus.