search

intel / intel-xpu-backend-for-triton

OpenAI Triton backend for Intel® GPUs
MIT License
137 stars 42 forks source link

Remove SPIRV 1.3 limit from target triple #1206

Closed whitneywhtsang closed 2 months ago

whitneywhtsang commented 4 months ago

In https://github.com/intel/intel-xpu-backend-for-triton/pull/1195, we changed target triple from spir64-unknown-unknown to spirv64v1.3-unknown-unknown, since some SPIR-V 1.4 features that are not backported to the SPIRV translator used by IGC. This issue is to track changing target triple back to spir64-unknown-unknown, when SPIRV 1.4 features are backported to the branch used by IGC, and delivered in a release driver.

whitneywhtsang commented 4 months ago

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/2533 is merged to llvm_release_180.

whitneywhtsang commented 3 months ago

@vlad-penkin Please feel free to assign this issue back to me once an external ticket is created.

whitneywhtsang commented 2 months ago

Tested with pre-released agama driver 950.4, test/unit/language/test_core.py::test_interleave[True] fails when changing from spirv64v1.3-unknown-unknown to spir64-unknown-unknown.

whitneywhtsang commented 2 months ago

Verified with agama 950.9, we can remove the workaround when it is released.