intel / intel-xpu-backend-for-triton

OpenAI Triton backend for Intel® GPUs
MIT License
109 stars 29 forks source link

Remove pytest.skip() (added from our team)in UT, check FAILED cases. #1434

Closed AshburnLee closed 1 week ago

AshburnLee commented 3 weeks ago
  1. Find all the "pytest.skip()" added by our team. Comment out them.
  2. Run all the tests, some of them may pass, some of them may fail.
  3. Check failed cases and see if they have already being tracked in the existing issues, if no, file a new issue to track.
  4. Remove "pytest.skip()" added by our team.
  5. Do the above on both Rolling & LTS.
AshburnLee commented 2 weeks ago

Status update on Rolling:

There are 19 pytest.skip that were added by our team, they are in a single test file: test_core.py. There are 166 FAILED cases, 6 of them have diff issue:

The above 5 cases are supposed to be skipped, checkout issue#223

Todo: I will put those cases in a skiplist and remove pytest.skip from code

AshburnLee commented 2 weeks ago

Update:

test_precise_math[1-tl.math.sqrt_rn(x)-tl.math.sqrt(x.to(tl.float64)).to(tl.float32)] has been tracked by https://github.com/intel/intel-xpu-backend-for-triton/issues/847 test_dot3d[*] has been tracked by https://github.com/intel/intel-xpu-backend-for-triton/issues/500

test_reduce[4-32-1-xor_sum-bool-shape173-1-False] test_reduce[4-32-1-xor_sum-bool-shape175-1-False] test_reduce[4-32-1-xor_sum-bool-shape177-1-False] test_reduce[64-16-1-xor_sum-bool-shape173-1-False] test_reduce[64-16-1-xor_sum-bool-shape175-1-False] test_reduce[64-16-1-xor_sum-bool-shape177-1-False] has been tracked by https://github.com/intel/intel-xpu-backend-for-triton/issues/1535

test_store_constant_default_dtype[1] has been tracked by https://github.com/intel/intel-xpu-backend-for-triton/issues/1534 test_dot_without_load[float16] has been tracked by https://github.com/intel/intel-xpu-backend-for-triton/issues/671 test_masked_load_shared_memory[dtype1] has been tracked by https://github.com/intel/intel-xpu-backend-for-triton/issues/671

test_tl_range has been tracked by https://github.com/intel/intel-xpu-backend-for-triton/issues/1541

test_dot_max_num_imprecise_acc[*] has been tracked by https://github.com/intel/intel-xpu-backend-for-triton/issues/1541

AshburnLee commented 2 weeks ago

Update:

test_reduce[4-32-1-xor_sum-bool-shape173-1-False] test_reduce[4-32-1-xor_sum-bool-shape175-1-False] test_reduce[4-32-1-xor_sum-bool-shape177-1-False] test_reduce[64-16-1-xor_sum-bool-shape173-1-False] test_reduce[64-16-1-xor_sum-bool-shape175-1-False] test_reduce[64-16-1-xor_sum-bool-shape177-1-False] has been tracked by https://github.com/intel/intel-xpu-backend-for-triton/issues/1535

Those 6 cases now passed. That issue has been closed 2 days ago

AshburnLee commented 1 week ago

Update:

AshburnLee commented 1 week ago

As discussed, skiplist for conda basekit build and test will not be created.