search

intel / intel-xpu-backend-for-triton

OpenAI Triton backend for Intel® GPUs
MIT License
129 stars 38 forks source link

Build with gcc9 #1528

Closed alexbaden closed 3 months ago

alexbaden commented 3 months ago

These fixes allow the Triton project to build under gcc-9. I had to unset the compiler variables to install test dependencies, though - I think there was conflict with DPCPP/SYCL. I also think we will need to modify the docker image to have gcc-9 available in the CI containers - will talk to @pbchekin next week.

cc #1505

whitneywhtsang commented 3 months ago

Have we decided to support build with gcc9? The change in the PR is fine, but does it limit our future development?

pbchekin commented 3 months ago

Have we decided to support build with gcc9? The change in the PR is fine, but does it limit our future development?

No, we haven't decided this yet, as far as I know. Also the triton package is much bigger when compiled with gcc 9 comparing to gcc 11:

gcc 9:  1.4G
gcc 11: 798M
alexbaden commented 3 months ago

Have we decided to support build with gcc9? The change in the PR is fine, but does it limit our future development?

I added this as a contingency in case we cannot use a newer version of gcc when creating PyTorch wheels. For main CI and development we should continue using a newer toolchain. If we decide we need to support gcc-9 beyond the current PyTorch release then we can create a nightly CI job or something similar - I wanted to explain why this PR didn’t currently include a test with my CI comment.

etiotto commented 3 months ago

I think this change is fine and can be merged in. @whitneywhtsang ok with you?

whitneywhtsang commented 3 months ago

I think this change is fine and can be merged in. @whitneywhtsang ok with you?

I don't have any problems with this change, my concern is more on wonder we need to support gcc9 long term.