search

intel / intel-xpu-backend-for-triton

OpenAI Triton backend for Intel® GPUs
MIT License
126 stars 36 forks source link

[Upstream] Try to upstream the supporting of the nested layout slice->dot->mma without LinearLayout #1843

Open chengjunlu opened 1 month ago

chengjunlu commented 1 month ago

The changes to the common TritonGPU dialect in the PR https://github.com/intel/intel-xpu-backend-for-triton/pull/1782

chengjunlu commented 3 weeks ago

Since we have supported the conversion to LinearLayout of the DPAS layout, we are not going to upstream the changes in legacy layout interface which is going to be rejected most likely.

The proper way is to support the conversion from dot layout to LinearLayout in upstream which is not supported yet.

@etiotto , @whitneywhtsang , Should we upstream the code to Triton or should we wait upstream to finish that?

whitneywhtsang commented 3 weeks ago

Since we already have the change, we can attend to upstream it (assuming the cost is low) with a comment in the description that the change is not needed when dot layout to linear layout conversion is supported, and ask when do they plan to support it. WDYT @etiotto @chengjunlu

chengjunlu commented 3 weeks ago

Since we already have the change, we can attend to upstream it (assuming the cost is low) with a comment in the description that the change is not needed when dot layout to linear layout conversion is supported, and ask when do they plan to support it. WDYT @etiotto @chengjunlu

Make sense. I will create the PR to upstream the changes and request for comments.

chengjunlu commented 3 weeks ago

Created an RFC to the public Triton: https://github.com/triton-lang/triton/pull/4598

chengjunlu commented 2 weeks ago

The PR has been rejected.

This is blocked. Need to wait the upstream to support the DotOp layout to LL conversion.