Closed locnnil closed 6 months ago
Review and code testing in progress.
Jenkins & Functionality Testing Passed
Hi @locnnil,
Could you please squash the 2 commits into 1? This would help make the history much cleaner and more useful for later inspection and analysis, such as when using git blame
and git bisect
.
@YongLiang2022 Sure, no problem! Done!
The PR review is to check for sustainability and correctness. Sustainability is actually more business critical as correctness is largely tested into the code over time. Its useful to keep in mind that SW often outlives the HW it was written for and engineers move from job to job so it is critical that code developed for Intel be supportable across many years. It is up to the submitter and reviewer to look at the code from a perspective of what if we have to debug this 3 years from now after the author is no longer available and defect databases have been lost. Yes, that happens all the time when we are working with time scales of more than 2 years. When reviewing your code it is important to look at it from this perspective.
Author Mandatory (to be filled by PR Author/Submitter)
PULL DESCRIPTION (to be filled by PR Author/Submitter)
Provide a 1-2 line brief overview of the changes submitted through the Pull Request...
REFERENCES (to be filled by PR Author/Submitter)
Reference URL for issue tracking (JIRA/HSD/Github): \
label: ISDM_Low
CODE MAINTAINABILITY (to be filled by PR Author/Submitter)
UPSTREAM EXPECTATIONS (NA for STAR)
Maintainer Mandatory (to be filled by PR Reviewer/Approving Maintainer)
QUALITY CHECKS (to be filled by PR Reviewer/Approving Maintainer)
CODE REVIEW IMPACT (Optional - need to discuss with ISDM forum)
SECURITY CHECKS (NA for STAR)
Please check if your PR fulfills the following requirements:
if (x > INT_MAX-100)
instead ofif (x + 100 < x)
Code must act as a teacher for future developers