search

intel / iotivity-node

Node.js bindings for IoTivity
https://www.iotivity.org/
42 stars 44 forks source link

All: Update spec version to res.1.1.0 implented in IoTivity 1.2.0 #104

Closed rzr closed 7 years ago

rzr commented 7 years ago

Also align data models

Change-Id: I6236546ba8bb93416cbf8cd3ca2555ae3f3935c5 Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.745% when pulling 68eee8b8cc71aa0fd12104f2364c681a879e2b32 on TizenTeam:sandbox/pcoval/on/master/review into 0bf8090106f48ec40694671ff90707b4b6c0af7c on otcshare:master.

hansmbakker commented 7 years ago

@rzr @gabrielschulhof is there a reason why this pr is not yet merged (or why I shouldn't use it yet), other than a failing build?

Maybe if you'd rebase it on the current master it would work?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 87.083% when pulling e0c143c3de823b2caa3c2fa27ef7a9954601bdf3 on TizenTeam:sandbox/pcoval/on/master/review into ab0e6f3ddb98f647460356a61277738ee9d345b4 on otcshare:master.

gabrielschulhof commented 7 years ago

Sorry! Didn't have a chance to check it out yet.

On Mon, Feb 13, 2017 at 11:03 AM, Coveralls notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/10121223

Coverage remained the same at 87.083% when pulling e0c143c https://github.com/otcshare/iotivity-node/commit/e0c143c3de823b2caa3c2fa27ef7a9954601bdf3 on TizenTeam:sandbox/pcoval/on/master/review into ab0e6f3 https://github.com/otcshare/iotivity-node/commit/ab0e6f3ddb98f647460356a61277738ee9d345b4 on otcshare:master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/otcshare/iotivity-node/pull/104#issuecomment-279329394, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7k0SC34eghF3IPZMmoQ_sxtK6DaIaPks5rcBx3gaJpZM4LTAjg .

hansmbakker commented 7 years ago

Thank you!

rzr commented 7 years ago

you welcome, make sure it does not break anything:

I saw those alerts on IRC:

Change view : https://github.com/otcshare/iotivity-node/compare/ab0e6f3ddb98...a4c1fd306851 Build details : https://travis-ci.org/otcshare/iotivity-node/builds/201068030

Change view : https://github.com/gabrielschulhof/iotivity-node/compare/a95974660748...d2a0c160ef21 Build details : https://travis-ci.org/gabrielschulhof/iotivity-node/builds/201101546

Change view : https://github.com/gabrielschulhof/iotivity-node/compare/13cdbaa48c8e...a4c1fd306851 Build details : https://travis-ci.org/gabrielschulhof/iotivity-node/builds/201101557

gabrielschulhof commented 7 years ago

Because the tests entail doing actual network communication, sometimes they fail. Rarely though. I've restarted the two failed jobs.

On Mon, Feb 13, 2017 at 3:16 PM, rzr notifications@github.com wrote:

you welcome, make sure it does not break anything:

I saw those alerts on IRC:

Change view : ab0e6f3...a4c1fd3 https://github.com/otcshare/iotivity-node/compare/ab0e6f3ddb98...a4c1fd306851 Build details : https://travis-ci.org/otcshare/iotivity-node/builds/ 201068030

Change view : gabrielschulhof@a959746...d2a0c16 https://github.com/gabrielschulhof/iotivity-node/compare/a95974660748...d2a0c160ef21 Build details : https://travis-ci.org/gabrielschulhof/iotivity-node/ builds/201101546

Change view : gabrielschulhof@13cdbaa...a4c1fd3 https://github.com/gabrielschulhof/iotivity-node/compare/13cdbaa48c8e...a4c1fd306851 Build details : https://travis-ci.org/gabrielschulhof/iotivity-node/ builds/201101557

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/otcshare/iotivity-node/pull/104#issuecomment-279389483, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7k0SLUehRIXj-rMEc5nB8hUaJYDTl9ks5rcFeygaJpZM4LTAjg .